consolidate bootstrap docs #107116
Merged
consolidate bootstrap docs #107116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
T-bootstrap
|
r? @jyn514 |
|
I think those changes should wait for the |
rustbot
added
S-blocked
compiler-errors
changed the title
|
@ozkanonur you don't need to put (Unless you're doing it for some other reason, which I think may be confusing because r= is already used to mean "approved by" in the rust repo) |
onur-ozkan
force-pushed
the
consolidate-bootstrap-docs
branch
2 times, most recently
from
d3adf3a to
d0fa05c
Compare
onur-ozkan
force-pushed
the
consolidate-bootstrap-docs
branch
from
f3fd173 to
9060e70
Compare
onur-ozkan
added
S-waiting-on-review
|
rust-lang/rustc-dev-guide#1563 (comment) is merged, so this is no longer blocked. |
jyn514
reviewed
Jan 31, 2023
jyn514
added
S-waiting-on-author
onur-ozkan
force-pushed
the
consolidate-bootstrap-docs
branch
2 times, most recently
from
939588a to
c447e86
Compare
onur-ozkan
added
S-waiting-on-review
jyn514
reviewed
Feb 3, 2023
| @@ -236,63 +145,31 @@ build/ | |||
| # system will link (using hard links) output from stageN-{std,rustc} into | |||
| # each of these directories. | |||
| # | |||
| # In theory, there is no extra build output in these directories. | |||
| # In theory these are working rustc sysroot directories, meaning there is | |||
| # no extra build output in these directories. | |||
There was a problem hiding this comment.
Not sure we need to mention this in the docs, but I'm hoping at some point to distinguish these "public" sysroots from the one's we're using for bootstrap internally: https://rust-lang.zulipchat.com/#narrow/stream/326414-t-infra.2Fbootstrap/topic/Performing.20.60.2E.2Fx.2Epy.20dist.60.20results.20in.20a.20broken.20compiler.20at.20.2E.2E.2E
Signed-off-by: ozkanonur <work@onurozkan.dev>
onur-ozkan
force-pushed
the
consolidate-bootstrap-docs
branch
from
fa73de4 to
6558326
Compare
|
Thank you!! @bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 4, 2023
…iaskrgr Rollup of 3 pull requests Successful merges: - rust-lang#107116 (consolidate bootstrap docs) - rust-lang#107646 (Provide structured suggestion for binding needing type on E0594) - rust-lang#107661 (Remove Esteban from review queues for a while) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this diff, I tried to consolidate bootstrap documentations and remove the duplicated informations.
Coupled with rust-lang/rustc-dev-guide#1563
Resolves #90686
Signed-off-by: ozkanonur work@onurozkan.dev